Not signed in (Sign In)

SkillShare - A place to discuss Web Standards and Web Design topics

Categories

Vanilla 1.1.9 is a product of Lussumo. More Information: Documentation, Community Support.

General Design: New website for my sister, critics please

Bottom of Page

1 to 13 of 13

  1.  
    • CommentAuthorKyochew
    • CommentTimeJan 5th 2006 edited
     permalink
    Hi everyone !
    I just finished my sister's website, i would be more than happy if you could tell me what's wrong on it.

    http://www.marlenedi.com

    be cool though, cuz it's my second css-based. I got to fix some stuff for the css&xhtml validation.


    Thkx u all, by advance seeya

    PS : I got a problem with my "too-large faux borders" background in PNG, i had to put it a fixed width in px, which results a non-centered layout and worse an horrible scrollbar . have u ever meet this kind of problem ?
    • CommentAuthorDunk Ra
    • CommentTimeJan 5th 2006
     permalink
    Mate - if you're asking for peoples time you should make it as easy as possible for them!

    The correct address is http://www.marlenedi.com

    I really like those marks on each side of the main column, not sure about the font for the logo though. Overall, nice layout but some of the spacing needs tweaking, especially on the headings (Firefox Mac)
    •  
      CommentAuthortsk
    • CommentTimeJan 5th 2006 edited
     permalink
    Very clean. I like it.

    However you might consider some more padding on content pages, "Actualites" for example. Compared to the header+menu, the content si quite close to the container borders. Also you could conisder a taller line-height for your text, about 1.3 em or 1.4 em . It makes for a more relaxed reading and keeps the eye 'flowing' down the page more comfortable.

    I agree with Dunk Ra that the font for the logo it probably not the most insipired one, or it just leaves that impression because of the gradinet. Experiment with some matte colour (probably white).

    This is not part of the feedback but I've noticed some Flahs? coupled with XML for the photogallery. Can you please point out a straight-forward tutorial on how you managed that. I've seen some tuts on the net, but I'm not really the sharpest tool in the shed in what concernes XML so I'd like something simple to learn from, something simmilar to your gallery

    silly me, i just saw the link under it now. forget about that
    • CommentAuthorDunk Ra
    • CommentTimeJan 5th 2006
     permalink
    Yes, what tsk said about the extra padding ('Actualities' etc), it would really polish off the site.
    •  
      CommentAuthorSpookyET
    • CommentTimeJan 5th 2006
     permalink
    Say no to frames.
    • CommentAuthorKyochew
    • CommentTimeJan 5th 2006
     permalink
    Thkx guys for all ur remarks,
    Ur absolutly right for all the points u noticed.

    But i didn't get the "say no to frames", spookynet is not the first one referring to that, i don't get it, i mean, i didn't use any frame on that site.
    Someone lied to me ? :)
    Thkx anyway
    •  
      CommentAuthorSpookyET
    • CommentTimeJan 5th 2006
     permalink
    I right click to see the code, and I see 3 lines of frames code.
    • CommentAuthorGustavs
    • CommentTimeJan 5th 2006 edited
     permalink
    It's a good web page, though I would add more padding to the content as it looks too tight.
    • CommentAuthorKyochew
    • CommentTimeJan 5th 2006
     permalink
    Oh my godness, ur right spooky, how could i be so stupid.

    Ok i got it, that's the mark of my cheap hosting company, cuz there this is a domain pointing a directory... Too bad, anyway i was seriously thinking about changing to another one, actually it helps me in my decision... cool
  10.  permalink
    No frames. Frames are bad. I realize this may be out of your control for now, but please get rid fo them ASAP.

    <div id="headerwrapper">
         <div id="header">
              <div id="header-title"></div>
       	       <div id="header-pic"></div>
    	            <div id="header-nav">
     		         <div id="navcontainer">


    That is usually a good sign that you're abusing divisions. Infact, it's a great sign.
    Your CSS file(s) is too large and you're using hacks within it when hacks aren't needed. Even if they were, they should be conditional statements.
    Your need to style your body and html elements. A simple body { width: 660px; margin: 0 auto; } would save you a lot of trouble and wouldn't require you to define the width and margin in each block element (footer, header, etc).
    Also, get into the habit of global declarations. Something like * { margin: 0; border: 0; padding: 0; } would save you time and effort for two reasons.
    1. You do not need to do things like this: border: 0; margin: 0; padding: 0;.
    2. You only have margin and padding and borders where applied.

    Here is an attached image of what should be what. You can hopefully figure out the rest or just make another topic, I suppose? Your layout
    • CommentAuthorKyochew
    • CommentTimeJan 5th 2006
     permalink
    Thk u so much Master Yoda.
    Ur code explanations will be really helpful to me for the future. All make sense, that's the high point of ur post.

    Thkx again, i really appreciate.
  12.  permalink
    Also, I'm not sure if you know of FIR (instead of putting blank elements which is a big no-no) so here is a link, http://mezzoblue.com/tests/revised-image-replacement/index.php.

    For example,

    <h1>Welcome to my site!</h1>

    h1 { background: #fff url("image.ext") no-repeat; text-indent: -5000em; height: 100px; width: 500px; margin: 0 auto; }

    That way, CSSless browsers still get the h1 text and know what your site is about.
    • CommentAuthormartijn
    • CommentTimeJan 6th 2006
     permalink
    Looks great, did you make that striped background yourself?

1 to 13 of 13

  1.  
Add your comments
    Username Password
  • Format comments as (Help)
 
Back to Discussions Top of Page